search

rmaia / pavo

tools for the analysis of color data in R
http://pavo.colrverse.com
GNU General Public License v2.0
68 stars 17 forks source link

Convert D65 to photon flux #215

Closed thomased closed 3 years ago

thomased commented 3 years ago

My fault, but a user noticed that our D65 is still in normalised radiant flux, rather than normalised photon flux. Think it crept in as part of #204 & I forgot to make the conversion. Should just need a irrad2flux() call & renormalisation in the data processing script.

Bisaloo commented 3 years ago

Might it be worth adding an attribute to record whether a rspec object is in irrad or flux (if we know)?

thomased commented 3 years ago

Yeah a units attribute would be a great idea - nice one.

thomased commented 3 years ago

Done for now. We'll add units as part of offloading the built-in data to its own package, which I'd like to get to this year.