search

rmaia / pavo

tools for the analysis of color data in R
http://pavo.colrverse.com
GNU General Public License v2.0
68 stars 17 forks source link

Plot margins #220

Closed thomased closed 3 years ago

thomased commented 3 years ago

I've left jndplot() alone for now since I think it needs it. But otherwise the margin-fiddling is all removed. Some of the default plots look a touch sub-optimal as a result, but like you say that's up to users, as is the case with all plots.

thomased commented 3 years ago

I didn't test it just yet but just a couple of comments while browsing the code.

Additionally, I still see par(margins in explorespec() and projplot(). Is it necessary there as well?

projplot() no, cheers — fixed that. But I'm inclined to keep explorespec() as-is. Because it's multi-panel in nature I think it's simplest if we just set nice margins. And it's not a publication-grade plot, it's really just for diagnostic purposes.

thomased commented 3 years ago

Awesome — appreciate it. Yeah I had the same thought about the vignettes but agree it'll be easiest once merged in.

thomased commented 3 years ago

And no, legendtetra() appears broken on master too. Odd. There's an issue relating to the function more generally (#54) already, we can continue thinking about it there.