Closed Bisaloo closed 3 years ago
Hah, I'm on the other side of the fence. I did not think about modifying plot.rspec()
.
Some first thoughts but I can consider it more. Adding a new S3 method:
sensmod
objects in the futureplot.rspec()
plot.sensmod()
on their custom absorbance spectra without the need to hack the class attributeplot.sensmod()
whereas a if
/else
in plot.rspec()
would at best be documented somewhere in the already long documentation of plot.rspec()
and could easily be missedYep, all great points — especially complexity & future-proofing. Sold!
Oh cool, cheers! I was just imagining a simple check somewhere in
plot.rspec()
for the label-swap. I guess there could be other benefits for having a dedicated method? Haven't thought about it enough.