Make sure colcat() works for x = 0 and y = 0

rmaia / pavo

tools for the analysis of color data in R

http://pavo.colrverse.com

GNU General Public License v2.0

68 stars 17 forks source link

Closed Bisaloo closed 1 year ago

Bisaloo commented 1 year ago

Follow up of 813622edf1d94b4bc1f600d55388876b86ec22c2:

adds a test to ensure we don't reintroduce this bug in the future
fix the case when x = 0 and y = 0. The test added in the previous commit reveals that NA is by default coerced to NA_logical_ which still causes issues in the vapply() call
move y to the second ifelse() call to clarify that x & y are handled symmetrically
use p+/p- rather x+/x- when y = 0 for consistency

Fix #244

thomased commented 1 year ago

Ugh, you’d think I’d know by now to never rush a push before the end of the day…

Many thanks for the several catches there. Awesome.