search

rmaia / pavo

tools for the analysis of color data in R
http://pavo.colrverse.com
GNU General Public License v2.0
68 stars 17 forks source link

Expand merge #246

Closed thomased closed 1 year ago

thomased commented 1 year ago

Rejigged merge.rspec() so it can accept an arbitrary number of rspec objects. Added some tests to match, and fixed up the docs. It's still a little clunky, but it's necessary (I think...) to avoid a breaking changes. Is this otherwise a bad idea for reasons I haven't thought of?

thomased commented 1 year ago

Yeah on reflection I think you’re quite right. I threw this together quickly while playing with something else, but not sure it’s worth the risk.

The two df limit on merge.data.frame is curious though, I’d be interested to know more sometime. My guess is control, and inspiration from SQL. Better control of join types, keys etc.

Leaning toward just a richer example like you suggest then, but I’ll leave this here for a bit to think it over/chat.

thomased commented 1 year ago

Added the example - 9509cfbe2148f77d61a4233cff0d44caca15f0ae. Might leave it there for now then.