search

rmaksim / Sublime-Text-2-Inc-Dec-Value

increase / decrease of numbers, dates, hex color values, etc.
153 stars 18 forks source link

New issues with OSX key bindings #7

Closed jackbrewer closed 12 years ago

jackbrewer commented 12 years ago

I notice that the OSX key bindings have just been updated and they are causing me a few issues

'ctrl+up' and 'ctrl+down' are already in use globally (in OSX Lion) for mission control.

'ctrl+super+up' and 'ctrl+super+down' are already in use in Sublime for 'Swap Line Up' and 'Swap Line Down' which are incredibly useful shortcuts.

Any chance you could rethink the choice of replacement shortcuts? Thanks.

rmaksim commented 12 years ago

Write please your shortcuts and think together. Because we all are different plug-ins and kuroir offered his own version, and I'm unfortunately not Mac user - I can't recommend anything.

rmaksim commented 12 years ago

Аlso see a new proposal from the forum by natebeaty. What do you think the proposed combination of keys?

MarioRicalde commented 12 years ago

Oh my ! I forgot I have that one disabled. I'm looking at the proposal on the forum and I think it shouldn't be colliding with anything else. Going to send pull request in a bit.

MarioRicalde commented 12 years ago

Check my repo: https://github.com/kuroir/Sublime-Text-2-Inc-Dec-Value/commit/21ff8d2611dacc9f38624bfba916684996505dcd

jackbrewer commented 12 years ago

I agree with natebeaty's suggestion in his forum post. I can't see any immediate problems with these new shortcuts. I have just been working on the exact same pull request! Glad to know we are in agreement.

MarioRicalde commented 12 years ago

Great minds understand each other quicker ;)

rmaksim commented 12 years ago

Do I understand correctly - everyone agrees with this change?

MarioRicalde commented 12 years ago

3 of us are in here.

  1. Did the suggestion.
  2. Agreed.
  3. Agreed.

So pretty much yes ;)

On Wed, Jan 18, 2012 at 3:57 AM, rmaksim < reply@reply.github.com

wrote:

Do I understand correctly - everyone agrees with this change?

Reply to this email directly or view it on GitHub:

https://github.com/rmaksim/Sublime-Text-2-Inc-Dec-Value/issues/7#issuecomment-3543380

MarioRicalde commented 12 years ago

Thank you! You're awesome.

rmaksim commented 12 years ago

Fine, I closed the pull request

jackbrewer commented 12 years ago

Thanks, much appreciated.