search

rmangino / Dasmoto

Simple Codeacademy html project
0 stars 0 forks source link

SUMMARY #3

Open ghost opened 6 years ago

ghost commented 6 years ago

Criteria 1: HTML and CSS Linking

Criteria 2: Implementation of Design Specification and Content

Criteria 3: HTML Elements and Content

Criteria 4: CSS Selectors and Syntax

Overall Score: 14/16

Great job! Your project is near perfect, with only superficial changes needed to be made. You have a good understanding of the fundamentals. I really appreciated the cleanliness of your code, it is easy to read and navigate through. It would be great if you included some hover effects over the text, or a transition to add a bit of extra flair.

rmangino commented 6 years ago

Thank you for the feedback @dericka. I'm not certain why you'd recommend hover/"flair" given that we've covered neither of those topics to date. Personally, I'd be leery of possibly confusing people new to the field with superfluous details when they are probably struggling with just getting the basic syntax correct.

Also, while I agree that using ids for singleton use-cases it didn't make sense in this case as I thought about what changes might be required down the line.

I'm taking this intensive so that I can write an article about my experiences for a major tech blog afterwards. I've been a software engineer for over 20 years (Apple, Microsoft, and Intel). I'm wondering how much of this review is "cut and paste" work? Did you really look at each line of my submission?

Thank you for your time!

ghost commented 6 years ago

You're welcome! @rmangino

I recommended it because you demonstrated enough understanding of the project that maybe you would have enjoyed or desired another component that could've made it more difficult for you. You displayed no obvious signs of struggling. Which I am now finding out that my intuition was right.

In regards to the IDs, it works and it's organized which are the most important qualities in your code. I have seen generally that people naturally gravitate toward marking those sections as IDs so I just thought it might be a good suggestion.

That's interesting, I hope you enjoy the rest of the intensive. There is a standard set by which to grade your project, so in that sense there is a "cut and paste". I did open your project to look for any obvious visual discrepancies and then looked at the code for formatting/styling. Well done projects like yours are more difficult to grade because there isn't much to say. I had to really search for what I did find, so yes I did look at each line.

Hope you find the rest of your experience valuable, take care!

rmangino commented 6 years ago

Thank you so much for your reply @dericka. I've been spending a lot of time in the CA Slack channel and am, quite honestly, amazed that people new to the field are able to do as well as they are. I had three DMs yesterday from folks who are struggling to understand the difference between head and body or who are unsure how https:// differs from file://. It must be challenging for you to help people as they move into topics like Flexbox when the most basic topics still elude them.

Will you be the one who reviews the rest of my work or are the submissions assigned randomly?

Thanks again for the feedback and for taking the time to answer my questions.

Have an awesome weekend!

ghost commented 6 years ago

No problem @rmangino. I hope you had a nice weekend!

I haven't had a chance to moderate the slack channels yet, but I have done advising one on one for a while. Over time you see common sticking points in students, so there is a bit of knowing what's coming around the corner for them that makes it easier.

The project submissions are assigned randomly to a pool of available project reviewers.

No problem, let me know if there are any other questions you may have.

Take care!