search

rmarins / accord

Home for Open Source Managed File Transfer
12 stars 27 forks source link

Changes to the mappings from files to exchange buffers #4

Open darkmuse opened 11 years ago

darkmuse commented 11 years ago

In this forum thread:

http://forum.accordproject.org/Incorrectly-stripping-line-separators-from-data-exchange-buffers-td4024826.html

I mentioned that the mapping was being done incorrectly (it certainly didn't interoperate with the Odex product properly). Gabriel asked for some test code, so I added

/accord/odetteftp/core/src/test/java/org/neociclo/odetteftp/protocol/data/ExchangeBufferTest.java

I updated the NormalMapping.java and CompressionMapping.java classes to make them pass so take a look and see if you want to use that or make your own changes to fix it. We need to make this change as we need to interoperate with other Odex implementations but it will obviously break compatibility with any products that use the current Accord implementation!

Enjoy, Gary Barker

rmarins commented 10 years ago

Sorry taking to long to consider this pull-request. Please, could you sign the contribution agreement in order to get your contribution merged in the upstream Accord Project?

darkmuse commented 10 years ago

I'm sure I can Rafael, where is the agreement?

rmarins commented 10 years ago

https://docs.google.com/forms/d/10ugpTY25ovMgL-oHoSeHtWxAsYP00KYNB89LASxKkrc/viewform

darkmuse commented 10 years ago

Thank you, I'll have to run it by the lawyers at work just to cover us, but I don't think there will be an issue.

rmarins commented 10 years ago

Sure Gary, no problem.

darkmuse commented 10 years ago

Hi Rafael, I signed the agreement. Before you pull in any changes, do you want to take a look and see if there is a better way to write the tests for checking what data is sent over the wire?

On 3 December 2013 23:28, Rafael Marins notifications@github.com wrote:

Sure Gary, no problem.

— Reply to this email directly or view it on GitHubhttps://github.com/rmarins/accord/pull/4#issuecomment-29762904 .

G+: https://plus.google.com/u/0/104223712160178727877/posts FB: https://www.facebook.com/gary.barker.uk