search

rmariuzzo / Laravel-JS-Localization

🌐 Convert your Laravel messages and consume them in the front-end!
https://github.com/rmariuzzo/laravel-js-localization
MIT License
596 stars 170 forks source link

It's not possible to publish asset for Laravel 6.0 #137

Open oltreseba opened 5 years ago

oltreseba commented 5 years ago

The package seems to work in laravel 6.0, but it's not possible to publish assets.

Probably it's just necessary to add the version check in: https://github.com/rmariuzzo/Laravel-JS-Localization/blob/master/src/Mariuzzo/LaravelJsLocalization/LaravelJsLocalizationServiceProvider.php#L51, since nothing should change from laravel 5.

rmariuzzo commented 5 years ago

Would you be able to create a PR?

On Fri, Sep 20, 2019, 09:20 oltreseba notifications@github.com wrote:

The package seems to work in laravel 6.0, but it's not possible to publish assets.

Probably it's just necessary to add the version check in: https://github.com/rmariuzzo/Laravel-JS-Localization/blob/master/src/Mariuzzo/LaravelJsLocalization/LaravelJsLocalizationServiceProvider.php#L51, since nothing should change from laravel 5.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rmariuzzo/Laravel-JS-Localization/issues/137?email_source=notifications&email_token=AADLMH4JTQ6R7RW4DSS5NG3QKTEZ5A5CNFSM4IYXAHD2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HMVV6ZQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AADLMH6AJSVPGHJ3CPG2VL3QKTEZ5ANCNFSM4IYXAHDQ .

oltreseba commented 5 years ago

Pull request created.