search

rmariuzzo / Laravel-JS-Localization

🌐 Convert your Laravel messages and consume them in the front-end!
https://github.com/rmariuzzo/laravel-js-localization
MIT License
598 stars 171 forks source link

Support for Laravel 8 #151

Closed bjorkgard closed 3 years ago

bjorkgard commented 4 years ago

It is possible to add support for Laravel 8?

artsur commented 4 years ago

Good question! I try to find solution too.. I have tried to indicate - version of laravel-js-localization in composer.json ... "mariuzzo/laravel-js-localization": "", ...

and then got an error during the installation:

ErrorException

Undefined variable: langs

at vendor/mariuzzo/laravel-js-localization/src/Mariuzzo/LaravelJsLocalization/LaravelJsLocalizationServiceProvider.php:79 75▕ } elseif ($laravelMajorVersion === 5) { 76▕ $langs = $app['path.base'].'/resources/lang'; 77▕ } 78▕ $messages = $app['config']->get('localization-js.messages'); ➜ 79▕ $generator = new Generators\LangJsGenerator($files, $langs, $messages); 80▕ 81▕ return new Commands\LangJsCommand($generator); 82▕ }); 83▕

roldandvg commented 4 years ago

hello, is there an approximate date planned for the support update to laravel 8 ?, thanks

rmariuzzo commented 4 years ago

I'm gonna check that this week. Tomorrow, will invest a couple of mins to check that stack trace. Thank you all! Any extra help appreciated.

mjducharme commented 4 years ago

Is there something wrong with the pull request that was submitted for this?

https://github.com/rmariuzzo/Laravel-JS-Localization/pull/153

rmariuzzo commented 4 years ago

I see it passing, let's merge this!

rmariuzzo commented 4 years ago

Just code reviewed the PR and merged. Will create a new tag.

rmariuzzo commented 4 years ago

New tag/version created: https://github.com/rmariuzzo/Laravel-JS-Localization/releases/tag/v1.7.0 - Please test and let me know how it goes. Thanks for your efforts and patience.

asbiin commented 3 years ago

@rmariuzzo I confirm it's working with Laravel 8, you can close this issue

rmariuzzo commented 3 years ago

I apologize for my long reply. I will take a look this week.

On Fri, Mar 5, 2021, 13:15 Mirko Tebaldi notifications@github.com wrote:

Version 1.,7.0 has still the wrong requirements in its composer.json ! Please update composer.json to allow ^8.0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rmariuzzo/Laravel-JS-Localization/issues/151#issuecomment-791559122, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADLMH3PFV54FRTYUUYQTW3TCEGTXANCNFSM4REPJZDA .