rmariuzzo / Laravel-JS-Localization

🌐 Convert your Laravel messages and consume them in the front-end!
https://github.com/rmariuzzo/laravel-js-localization
MIT License
598 stars 171 forks source link

Request to enable support for PHP 8 #158

Closed realtebo closed 3 years ago

realtebo commented 3 years ago

Hi !

We're using this package since v1.2

A big project is now being migrated to PHP 8 and we discovered that v1.7 has a composer.json requirements for php 7.

Could you please extends supports for php 8?

rmariuzzo commented 3 years ago

Yes, I can do that.

On Fri, Mar 5, 2021, 13:17 Mirko Tebaldi notifications@github.com wrote:

Hi !

We're using this package since v1.2

A big project is now being migrated to PHP 8 and we discovered that v1.7 has a composer.json requirements for php 7.

Could you please extends supports for php 8?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rmariuzzo/Laravel-JS-Localization/issues/158, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADLMH5NYCGHGW6NMNGRCQDTCEGZ5ANCNFSM4YVSRMVA .

GENL commented 3 years ago

I suggest to use Matice: https://github.com/GENL/matice

rmariuzzo commented 3 years ago

I suggest to use Matice: https://github.com/GENL/matice

Hi @GENL!

I'm happy to include a reference for Matice in the README file of this project.

rmariuzzo commented 3 years ago

@realtebo I'm checking this now.

rmariuzzo commented 3 years ago

Just merged this: #154

rmariuzzo commented 3 years ago

Just published v1.8.0

realtebo commented 3 years ago

Thank you a lot

rmariuzzo commented 3 years ago

Lmk if it works for you

On Sat, Mar 6, 2021, 14:33 Mirko Tebaldi notifications@github.com wrote:

Thank you a lot

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rmariuzzo/Laravel-JS-Localization/issues/158#issuecomment-792010098, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADLMH37FYX6UKUSLWC4I2DTCJYN5ANCNFSM4YVSRMVA .

realtebo commented 3 years ago

It works fine with PHP 8 and larevel 8.x, thanks

rmariuzzo commented 3 years ago

Thank you for your feedback @realtebo !