search

rmariuzzo / Laravel-JS-Localization

🌐 Convert your Laravel messages and consume them in the front-end!
https://github.com/rmariuzzo/laravel-js-localization
MIT License
596 stars 170 forks source link

Laravel 9 support #164

Closed HadrienX closed 2 years ago

HadrienX commented 2 years ago

Laravel 9 was released today.

Please update your package settings to add PHP 8 and Laravel 9 support.

Current error :

mariuzzo/laravel-js-localization v1.7.0 requires php ^5.4 || ^7.0 -> your php version (8.0.3) does not satisfy that requirement.

ahoiroman commented 2 years ago

Should be solved with https://github.com/rmariuzzo/Laravel-JS-Localization/pull/162

rmariuzzo commented 2 years ago

I'm deploying a new version now.

rmariuzzo commented 2 years ago

Finally, was able to publish the new release.

HadrienX commented 2 years ago

I just found an error on Laravel 9. The lang directory has moved from /resources/lang directory to /lang directory on fresh install.

In LaravelJsLocalizationServiceProvider@register method of this package, the lang directory is defined to : $app['path.base'].'/resources/lang' on Laravel > 5.

I guess the best way to handle Laravel 9 new language directory is to add a new config variable to define the lang directory.