Open SanderSander opened 2 years ago
I updated the PR because of the prev commit was reverted (This PR includes those changes).
BTW, I think the original commit adds a feature, so instead releasing it as 1.9.1
a patch version, maybe consider to release it as a minor version 1.10.0
Any news guys? I'm on Laravel 9 and I had to change the file directly to support the /lang folder instead of /resources/lang
I apologize for the slow response. Will chech that today.
Hi @rmariuzzo, any idea when this fix will be released? This issue is still causing many headaches for people using Laravel 9, and Laravel 10 is around the corner...
@jonaszkadziela I recall we fixed the issue the day it was discovered by reverting breaking changes; update your dependency to the newest version (1.9.0) and you should be good to go.
@jonaszkadziela I recall we fixed the issue the day it was discovered by reverting breaking changes; update your dependency to the newest version (1.9.0) and you should be good to go.
Looking at the LaravelJsLocalizationServiceProvider
class, it still does not locate files in the new default path which is project_root/lang
:
https://github.com/rmariuzzo/Laravel-JS-Localization/blob/v1.9.0/src/Mariuzzo/LaravelJsLocalization/LaravelJsLocalizationServiceProvider.php#L75
Therefore, any fresh Laravel 9.x application or existing project that uses the new path does not work with this package. Running php artisan lang:js -c
command leads to the following exception:
So, unfortunately, version 1.9.0 is not working. If this PR is merged, the issue should be resolved.
I'm gonna take a look at this today, in a couple of hours.
Guys, is this fix released?
Fixes for the paths in v1.9.1