Bug fixes and other minor changes - Githubissues

rmartin5 / aqua-sim-ng

Aqua-Sim on NS3

85 stars 42 forks source link

Bug fixes and other minor changes #1

Closed dcentelles closed 6 years ago

dcentelles commented 6 years ago

Fixes:

passing packet size argument as number of bits to AquaSimPhyCmn::CalcTxTime
define conflict in aqua-sim-mac-alogha.h with SystemCondition::Broadcast(void) in ns3/system-condition.h.
AquaSimRoutingDummy. Change range to 22 in line 63 of bMAC.cc to reproduce this bug. Packets should be received and retransmitted well without entering in an infinite loop.

Extras:

2 additional TracedCallbacks in ns3::AquaSimRouting (similar to TraceSources RoutingTx and RoutingRx. Maybe this is redundant...)

rmartin5 commented 6 years ago

Thanks for the fixes! While there may be potential for some redundancy from the trace cb I would rather have them implemented allowing for less modifications from novice simulator users.