search

rmawatson / flutter_isolate

Launch an isolate that can use flutter plugins.
MIT License
262 stars 80 forks source link

[Feature] android: use FlutterEngineGroup for better perf #150

Closed chipweinberger closed 7 months ago

chipweinberger commented 7 months ago

As the title says, use FlutterEngineGroup for better perf on android.

There is a separate PR for iOS: https://github.com/rmawatson/flutter_isolate/pull/151

this closes https://github.com/rmawatson/flutter_isolate/issues/149 https://github.com/rmawatson/flutter_isolate/issues/111 https://github.com/rmawatson/flutter_isolate/issues/73

I've tested these changes on Android 13 and Flutter 3.16.8

About me, I am the maintainer of these packages, so I am pretty familiar with flutter plugins

nmfisher commented 7 months ago

Thanks @chipweinberger - as you saw, this has been on my radar for quite a long time. I appreciate the effort! I've only just moved house so I'm a bit off schedule, give me a couple of days to look through this and I'll review soon.

chipweinberger commented 7 months ago

No worries. good luck with the move Nick!

chipweinberger commented 7 months ago

hope the move went well @nmfisher , just wanted to ping you again.

Also, I'm open to being a contributer if you prefer that.