[WIP] Enhance scrapy-redis

rmax / scrapy-redis

Redis-based components for Scrapy.

http://scrapy-redis.readthedocs.io

MIT License

5.52k stars 1.59k forks source link

[WIP] Enhance scrapy-redis #204

Closed whg517 closed 2 years ago

whg517 commented 2 years ago

ref #203

Task list

[x] Added GitHub Action workflow
[x] Add pep-0517 A build-system independent format for source trees support
[x] Added adaptation from Python 3.7 to Python 3.10, and removed Python 2 support
[ ] Add Type annotations pep-0483
[ ] Add pytest to test project
[ ] Use modern sphinx theme -- furo , like pip document

whg517 commented 2 years ago

Thank you for your recognition. If you have any questions, please raise them in time and I will make modifications.

LuckyPigeon commented 2 years ago

Seems too many changes in a PR to me.

LuckyPigeon commented 2 years ago

@Germey Can you help review this?

Germey commented 2 years ago

@LuckyPigeon I think there're also too many changes in this PR. @whg517 Could you please split these changes into multiple PRs, every PR for every TODO?

I don't think this large PR can be accepted.