rmax / scrapy-redis

Redis-based components for Scrapy.
http://scrapy-redis.readthedocs.io
MIT License
5.52k stars 1.59k forks source link

[update] Update github action #277

Closed LuckyPigeon closed 1 year ago

LuckyPigeon commented 1 year ago

Description

Update GitHub Action to support python3.11.

Fixes #273

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist:

LuckyPigeon commented 1 year ago

pylint check failed due to python3.11.3 issue, check this for detail.

rmax commented 1 year ago

I'm seeing that others opted to disable pylint meanwhile it gets fixed.

Do you think that's a good option here?

I couldn't figure out if warpt has fixed the issue or not :/

LuckyPigeon commented 1 year ago

wrapt has already fixed the issue, now only use from wrapt import formatargspec instead of from inspect import formatargspec. But seems python team hasn't change the usage.

I'll disable pylint for the meanwhile.

LuckyPigeon commented 1 year ago

And for the pytest failed, seems the new fingerprint implements differently than before, check the official implementation. So, I will rollback to previous request_fingerprint for the meanwhile, then implements our own request_fingerprint in another PR.

LuckyPigeon commented 1 year ago

@rmax I think that's about it. Over all, we stopped pylint for now and do the full checking of python3.11 support, now the rests are setup.py, pip and our next release.