Closed LuckyPigeon closed 1 year ago
@rmax Do we need a unit test for this implementation? This function might not be called by others, right?
My suggestion would be to refactor the fingerprint method logic into a function and unit test the behavior of this function:
Sounds great.
@rmax done!
Description
request_fingerprint
is deprecated inScrapy
, but newfingerprint
function requires a lot of changes of our code. Thus we need a customizefingerprint
implementation for our own.Unittests
are also implemented, there are three newunittests
test_request_seen
withsame_request
diff_method
diff_url
Fixes #272
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: