search

rmcauley / rainwave

Rainwave Site and Radio Controller
http://rainwave.cc
GNU General Public License v2.0
192 stars 38 forks source link

Track title no longer updating when used with players like mpd or mpv #160

Open Earnestly opened 3 years ago

Earnestly commented 3 years ago

For some time now the title/artist metadata no longer updates to reflect what is playing, instead the title falls back to the url such as http://allrelays.rainwave.cc/all.ogg.

Is this a known issue or something that can be fixed?

rmcauley commented 3 years ago

When we upgraded to the Opus codec, we found out pretty quickly that unfortunately Chrome (and a few others - but most importantly Chrome) did not support metadata/Ogg tags as part of the Opus stream to be supported.

Apparently this can be worked around with old, old, old school ICY tags for old, old, old school players like MPD and Foobar.

Here's the Chromium issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1161429&q=opus&can=2

You'll see that I have commented on this issue myself. :) (comment number 8)

Rather than go back to Vorbis, I decided to continue with Opus. I'm sorry for this, but it's the sad reality that the majority of listeners, the increase in audio quality is worth the lack of metadata, since those of us tuning in using only external players is vanishingly few these days. The last time I measured about a year ago, the vast majority of listeners are through the website or mobile apps. 2nd is Minecraft. 3rd is Euro Truck Simulator. (yes)

rmcauley commented 3 years ago

Looking over that bug report, it seems to have devolved entirely. I may have to spin up a local Rainwave and provide a much more concrete bug report to the Chromium team.

Earnestly commented 3 years ago

Yeah it's nice to have opus, I agree there.

Am I understandingly correctly that metadata was removed specifically from opus so that chromium itself could handle the stream? And that if chromium managed to fix this bug then the metadata can eventually be reinstated?

If this the case then I think it's perfectly reasonable to wait on chromium. It appears the mp3 stream still works (using icy-title tags) so I'll use that in the mean time.

rmcauley commented 3 years ago

Am I understandingly correctly that metadata was removed specifically from opus so that chromium itself could handle the stream? And that if chromium managed to fix this bug then the metadata can eventually be reinstated?

Yes, that is correct.

If this the case then I think it's perfectly reasonable to wait on chromium. It appears the mp3 stream still works (using icy-title tags) so I'll use that in the mean time.

Yes, that is also correct. You will not have the same audio quality as the Opus stream, but you will have metadata.

Earnestly commented 3 years ago

This much is true. The issue might be worth keeping simply to cross-reference the chromium bug until that is fixed, which is the proper place for it.

PS: Thank you for the detailed response and explaining the reasons for this, it does seem a bit esoteric otherwise.