search

rmcelreath / stat_rethinking_2022

Statistical Rethinking course winter 2022
4.12k stars 445 forks source link

error still in Lecture 9 marginalized effect example? #14

Closed benslack19 closed 2 years ago

benslack19 commented 2 years ago

Hi, I think you said that the error from lecture 9 is fixed, but I'm wondering if an error is still there on slide 75 and 76?

For example on slide 75, there's this code where link refers to model m2:

# simulate as if all apps from women
p_G1 <- link(m2,data=list(
D=rep(1:6,times=apps_per_dept),
N=rep(1,total_apps),
G=rep(1,total_apps)))

But in the lecture code, the model now refers to mGD.

# simulate as if all apps from women
p_G1 <- link(mGD,data=list(
    D=rep(1:6,times=apps_per_dept),
    N=rep(1,total_apps),
    G=rep(1,total_apps)))
rmcelreath commented 2 years ago

mGD is right. See https://github.com/rmcelreath/stat_rethinking_2022/commit/2542781137bc9033294b651132dcf666e1d8112f

benslack19 commented 2 years ago

Ok thanks. To confirm, the slide still needs to be correctedl?