search

rmcrackan / Libation

Libation: Liberate your Library
GNU General Public License v3.0
2.81k stars 153 forks source link

Selection of 64kbps or 128kbps instead of default 128kbps #648

Closed Malaya2100 closed 1 year ago

Malaya2100 commented 1 year ago

Hi,

I would like to thank you for the little incredible software.

Is it possible to integrate a setting of selecting 64kbps or 128kbps instead of default 128kbps while downloading?

Regards, Malay

Mbucari commented 1 year ago

I like this idea. Tbh I often change the requested download quality in code when I want the smaller file sizes. I agree this should be a feature, but it's complicated by one thing: Libation stores and displays the highest available audiobook quality.

Since Libation only downloads the highest quality, that bitrate field always matches the download files' bitrate. If bitrate becomes a setting then that field may be wrong.

@rmcrackan any ideas how to deal with this?

rmcrackan commented 1 year ago

Off the top of my head: instead of storing the single value, it could be an array of all options. You could just shove it into a json string and into a field, it wouldn't need to be searchable or performant. The judgement call is: what about when you don't have a match? Would a user want that as their maximum value, or minimum? My guess is, if they don't want 'best available', this that would be their max. If no value less than or equal to that exists, then use the lowest available.

Malaya2100 commented 1 year ago

I hope to welcome this feature in future update.

Thank you guys, Malay

rmcrackan commented 1 year ago

Will be available in version 10.5. Coming very soon.

Malaya2100 commented 1 year ago

Hi Guys,

If I'm not mistaken, I think the "Normal" downloads at 32kbps and "High" Downloads at 128kbps.

But, the question is about how to download at 64kbps which may be termed as "Medium" or whatever.

Hope, you will integrate this too.

Thank you, Malay

On Tue, Jul 4, 2023, 7:38 AM rmcrackan @.***> wrote:

Closed #648 https://github.com/rmcrackan/Libation/issues/648 as completed.

— Reply to this email directly, view it on GitHub https://github.com/rmcrackan/Libation/issues/648#event-9715871446, or unsubscribe https://github.com/notifications/unsubscribe-auth/BA432R6YCEIFH2WHZ4O2XZDXON3LRANCNFSM6AAAAAAZW253FI . You are receiving this because you authored the thread.Message ID: @.***>

Mbucari commented 1 year ago

@Malaya2100 There are only 2 quality options for audio quality on Audible: Normal and High. Depending on the book, Normal may be 32 kbps 22kHz or 64kbps 22kHz and High may be 64kbps 44.1kHz or 128kbps 44.1kHz. It varies title to title.

Try it on your phone app. Download a book in Normal quality and again in High. Look at the bireate and sample rate.