search

rmcrackan / Libation

Libation: Liberate your Library
GNU General Public License v3.0
2.56k stars 138 forks source link

Question mark in book title causes failure to save #911

Open Torquill opened 4 months ago

Torquill commented 4 months ago

When liberating a book with a question mark in the title, the file downloads, then aborts when attempting to save.

To reproduce:

  1. Add a book with a question mark in its title to your Audible library. My example: "Whose Midlife Crisis Is It Anyway?" by Robyn Peterman.
  2. Scan library with Libation.
  3. Liberate the title in question.
  4. See the operation fail.

Expected behavior: To successfully download and save the file to disk. Failing that, to get an informative error message.

Workaround: I hard-coded the title without the question mark into the file settings, completed the operation, then changed all the settings back. Apparently my assumption that this was the problem was correct.

Platform: Linux, Debian 13 (trixie), amd64

Log: 6/1/2024 3:24PM Download & Decrypt Step, Begin: [B09233BM3M] Whose Midlife Crisis Is It Anyway?: The Good to the Last Death Series, Book 2 6/1/2024 3:27PM Download & Decrypt Step, Completed: [B09233BM3M] Whose Midlife Crisis Is It Anyway?: The Good to the Last Death Series, Book 2 6/1/2024 3:27PM Download & Decrypt 6/1/2024 3:27PM ERROR. All books have not been processed. Most recent book: processing failed 6/1/2024 3:27PM ERROR: Invalid argument : '/media/torquill/Peregrine24/Audio/Audible/Robyn Peterman - Whose Midlife Crisis Is It Anyway?' 6/1/2024 3:30PM Download & Decrypt Step, Begin: [B09233BM3M] Whose Midlife Crisis Is It Anyway?: The Good to the Last Death Series, Book 2 6/1/2024 3:32PM Download & Decrypt Step, Completed: [B09233BM3M] Whose Midlife Crisis Is It Anyway?: The Good to the Last Death Series, Book 2 6/1/2024 3:32PM Download & Decrypt 6/1/2024 3:32PM ERROR. All books have not been processed. Most recent book: processing failed 6/1/2024 3:32PM ERROR: Invalid argument : '/media/torquill/Peregrine24/Audio/Audible/Robyn Peterman - 2/Whose Midlife Crisis Is It Anyway? - 01 (1).mp3'

CLHatch commented 4 months ago

I'm not sure where the matching functionality is in the Linux version, but in Windows you handle characters like that with a replacement list. Generally they'd be replaced with the Unicode equivalent character.

image