Resolve 9 FindBugs bugs - Githubissues

rmct / AutoReferee

Bukkit plugin for automatically refereeing competitive Minecraft matches.

http://rmct.github.com/AutoReferee

GNU General Public License v3.0

35 stars 19 forks source link

Resolve 9 FindBugs bugs #186

Closed riking closed 10 years ago

riking commented 10 years ago

Resolved:

team.getExpectedPlayers() is a collection of String, not Player
setConsoleWorld(String) might pass null into setConsoleWorld(World) which then calls world.getUID(). This is replaced with setting explicit null (the startup value).
(x3) SportBukkitUtil must be prepared to encounter Errors as well as Exceptions and ignore them too
(x3) Renaming Exception parameters to 'ignored' when they are ignored
Comment out unused player in unit test

Unresolved:

The fields of MatchParams and TeamInfo are never written by code
CombatListener is guaranteed to reference vapl, despite there being a nullcheck there

authorblues commented 10 years ago

Pulled via https://github.com/rmct/AutoReferee/commit/144937650e2ed9139dbbfd124f17ed4f01ed9218. Thanks!