search

rmculpepper / iracket

Jupyter kernel for Racket
BSD 3-Clause "New" or "Revised" License
95 stars 14 forks source link

Add a kernel parameter to create a trusted sandbox #14

Closed mpcjanssen closed 3 years ago

mpcjanssen commented 3 years ago

Fixes #13

rmculpepper commented 3 years ago

Thanks for the PR! There is one issue, which is that call-with-trusted-sandbox-configuration does not set the parameters listed under "Not set by call/trusted" in the code of call-with-kernel-sandbox-configuration. The most important is sandbox-namespace-specs: without that setting, the picts in the Getting Started example notebook don't render as images.

mpcjanssen commented 3 years ago

@rmculpepper I have created a separate configuration proc for the trusted scenario. Networking still works and images display correctly again.

mpcjanssen commented 3 years ago

@rmculpepper anything remaining to have this merged?

rmculpepper commented 3 years ago

I think this is good. Thanks!