search

rmdmattingly / RowlogAnalysis

MIT License
5 stars 0 forks source link

Added Arg Parse support #39

Closed taddyb closed 4 years ago

taddyb commented 4 years ago

Description

Added argparse support

Test

Tested all the functions

Will write more meaningful PR in a bit

rmdmattingly commented 4 years ago

I like this a lot, I just noticed that this is a lot of added dependencies in the requirements.txt. Are they all necessary? My boss said something to me the other day along the lines of "engineering is 70% dependency management" -- a really easy way to slow things down is to add lots of overhead here. They might all be necessary, I just wanted to make sure because it seemed disproportionately large compared to the changes.

taddyb commented 4 years ago

@rmdmattingly Just merged all changes in main.py and tested all of the services. When using argparse you see the following messages for bad calls: 

$ python main.py fa6ztXp searchByComment -o
usage: Rowlog Analyzer [-h] [--query QUERY] Team Code Service
Rowlog Analyzer: error: unrecognized arguments: -o
usage: Rowlog Analyzer [-h] [--query QUERY] Team Code Service
Rowlog Analyzer: error: argument --query/-q: expected one argument

and for an empty searchByComment call you see this:

$ python main.py fa6ztXp searchByComment -q dasdasdas
[]

I edited the requirements.txt file to address your dependency issues. I think the pytest package added a lot of those. All services work with the new file.