search

rmed / pyemtmad

(Kind of) sane wrapper for the EMT Madrid API
GNU General Public License v2.0
5 stars 4 forks source link

Write unit tests #2

Open rmed opened 8 years ago

rmed commented 8 years ago

Given that the EMT API changes over time, it would be nice to have unit tests to check the library works as expected. These tests should take into account the official documentation at: http://opendata.emtmadrid.es/Servicios-web (which might be outdated)

PaskoMoto commented 6 years ago

Hi. I'm having issues with method get_nodes_lines(). Can't get the full list of nodes. Also selecting specific nodes sometimes works and sometimes doesn't. Maybe the API has changed again? Regards.

PaskoMoto commented 6 years ago

Hi. Update: I already found the problem. Turns out I was not using the most recent version of pyemtmad. Thank you very much for this software. Regards.

rmed commented 6 years ago

Glad to hear it worked out in the end

PaskoMoto commented 6 years ago

Hi. I also found a new attribute for NodeLinesItem (Wifi). There's only one Node with Wifi == 1 ('Palacio de la Moncloa') though. So this is not a real issue. I may issue a PR if you want. That's a simple change. :D Regards.

PaskoMoto commented 6 years ago

Hi again. I'm using your wrapper to build an app for SailfisOS enabled devices and would like you to know. I will of course mention your software in my app but would like to let you know just in case. Feel free to contact me of you want more details :-D Regards.

rmed commented 6 years ago

Hi there, that sounds great! Hope the library doesn't give you much trouble

PaskoMoto commented 6 years ago

Thanks!