search

rmehri01 / onenord-jetbrains

🏔️ A theme for JetBrains IDEs that combines the Nord and Atom One Dark color palettes for a more vibrant programming experience.
https://plugins.jetbrains.com/plugin/20772-onenord
MIT License
23 stars 2 forks source link

The toolbar in the data view is broken #10

Closed tateren closed 1 year ago

tateren commented 1 year ago

Thanks for the great theme!

It seems that the toolbar rendering is broken when a color is set in the database. This does not occur when colors are not set in the database or when another theme is used.

2023-08-23 14_21_56-Window

Product and version: PhpStorm 2023.2 Operationg system: Windows 11 Plugin version: 0.0.6

rmehri01 commented 1 year ago

Hey there, thanks I'm glad you like the theme! 😄

Hmm, it seems like a few toolbars overlapping, which shouldn't be controlled by the plugin but its strange that it only happens with this theme.

I can't seem to reproduce it on my mac, though I'm not that familiar with using the data tools. I basically just loaded up a sample SQLite database and right clicked on one of the tables, then did Tools > Set Color and got this result:

Screenshot 2023-08-23 at 10 27 12 AM

Do you have any other details on how to reproduce it?

tateren commented 1 year ago

When hovering the mouse over the toolbar, the drawing is corrupted. It seems that some colors reproduce and some do not.

20230825

This problem occurred even when I did Restore Default Setting and minimized the configuration. This also occurs with another product (DataGrip).

rmehri01 commented 1 year ago

Ah okay interesting, I can reproduce something similar now when using different colors thanks, I'll look into it!

rmehri01 commented 1 year ago

So I believe the issue is that these colors are taken from FileColors, which right now have alpha values. These seem to work in other places in the editor but not in this toolbar and I've been able to reproduce this issue in a few other themes including Nord and Gradianto that also have alpha values in their FileColors.

I've asked about it on the JetBrains Slack to see if it is officially supported or not because I think it looks nicer with the transparency but if it isn't supported I'll change the colors to a darker variation to make it work without transparency.

tateren commented 1 year ago

Thank you for investigating. For the time being, I'll try to work around the problem by setting Custom Color.

rmehri01 commented 1 year ago

I don't seem to be getting a response, so I'm just going to make the FileColors not have alpha values in them.

rmehri01 commented 1 year ago

Should be fixed in the next release! 😄

tateren commented 1 year ago

Thanks a lot!