search

rmeitl / Local-Report-Issue-Tracking

0 stars 0 forks source link

Removal Rates Table #6

Open mvalentino opened 8 years ago

mvalentino commented 8 years ago

In the Removal Lbs/Unit 1 table for each local watershed, the Stream Restoration - Pasture, Coastal Plain (LF) and Stream Restoration - Pasture, Non-Coastal Plain (LF) are referencing the incorrect BMP Efficiency from the MA_BMP_EFFICIENCY lookup table for TSS-EOS and TSS-DEL. It looks like the calculation has the two BMP types switched for the TSS calulation.

rmeitl commented 8 years ago

Missy @mvalentino and/or Megan @mcrunkleton

Can you give me the proper TSS calculation for all of the Stream Categories? Jeff asked me to make sure that all of our lookup tables were up to date. I thought I had looked at this and compared it to the latest lookup table in Megan's Model Automation folder, but I may have actually goofed it up, since this was the only value I touched. We should look at the MA_BMP_EFFICIENCY table, and compare it to whatever the real TSS values should be. Thanks!

mvalentino commented 8 years ago

According to the Accounting protocol, the Stream Restoration Coastal Plain TSS is 15.1 and non-Coastal Plain is 44.9. I will also review the others.

mcrunkleton commented 8 years ago

TSS removal for streams is calculated as lbs reduced/linear feet; which, you have correctly noted in the attribute column "NUTRIENT_NOTE" of the MA_BMP_EFFICIENCY table. We do not have lbs removed/lf values for pasture land use, so in the interim we are using the urban stream values for pasture. TSS = 15 for Coastal Plain streams and 45 for Piedmont streams (or "Non-Coastal Plain" as it's described in the look-up table). This geography will change based on the MS4 County. You have the correct values for TSS in the look-up table for each line item (pasture/urban Coastal Plan and Non-Coastal Plain). Do we need to create another look-up table that defines which MS4 counties are Coastal Plain and which are Piedmont? I am not sure how that was being identified in the scripts.

rmeitl commented 8 years ago

@mohsinkar There is an issue here. Look at "Stream Restoration- Pasture, Coastal Plain" and "Stream Restoration - Pasture, Non-Coastal Plain". Make sure that the red cells for the removal lbs/unit are looking to the MA_BMP_EFFICIENCY for their values for TSS. I had updated the table before running these reports, and it seems that it may be hard coded? Something is fishy.

for coastal plain = 15. for non-coastal plain = 45.

stream_tss

stream_tss2

rmeitl commented 8 years ago

@mohsinkar Can you take a look at this. See latest comment from me.

rmeitl commented 8 years ago

@mohsinkar can we close this one out as well?

Look at "Stream Restoration- Pasture, Coastal Plain" and "Stream Restoration - Pasture, Non-Coastal Plain". Make sure that the red cells for the removal lbs/unit are looking to the MA_BMP_EFFICIENCY for their values for TSS. I had updated the table before running these reports, and it seems that it may be hard coded?

for coastal plain it should = 15. for non-coastal plain = 45.

rmeitl commented 8 years ago

@mohsinkar - The cell for reference highlighted in red above is still incorrect. Can you check this? Cells H43 and H45 in all of the watershed tabs. And verify the calcs for the subsequent TSS-DEL values by year.

rmeitl commented 8 years ago

@mohsinkar - this still needs to be fixed