search

rmisev / url_whatwg

An implementation of the WHATWG URL Standard in C++
https://upa-url.github.io/docs/
Other
9 stars 0 forks source link

Refactor to use validation errors (enum class validation_errc) #13

Closed rmisev closed 8 months ago

rmisev commented 9 months ago

The validation errors used are defined at: https://url.spec.whatwg.org/#validation-error

Follows: https://github.com/whatwg/url/commit/d84610fd2f68319b62e91106eeedcef08ee0466e

codecov[bot] commented 9 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (011c39f) 99.09% compared to head (72bcabf) 99.72%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #13 +/- ## ========================================== + Coverage 99.09% 99.72% +0.63% ========================================== Files 15 15 Lines 2202 2213 +11 ========================================== + Hits 2182 2207 +25 + Misses 20 6 -14 ``` | [Files](https://app.codecov.io/gh/rmisev/url_whatwg/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rimas+Misevi%C4%8Dius) | Coverage Δ | | |---|---|---| | [include/upa/url.h](https://app.codecov.io/gh/rmisev/url_whatwg/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rimas+Misevi%C4%8Dius#diff-aW5jbHVkZS91cGEvdXJsLmg=) | `99.74% <100.00%> (ø)` | | | [include/upa/url\_host.h](https://app.codecov.io/gh/rmisev/url_whatwg/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rimas+Misevi%C4%8Dius#diff-aW5jbHVkZS91cGEvdXJsX2hvc3QuaA==) | `100.00% <100.00%> (ø)` | | | [include/upa/url\_ip.h](https://app.codecov.io/gh/rmisev/url_whatwg/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rimas+Misevi%C4%8Dius#diff-aW5jbHVkZS91cGEvdXJsX2lwLmg=) | `100.00% <100.00%> (ø)` | | | [include/upa/url\_result.h](https://app.codecov.io/gh/rmisev/url_whatwg/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rimas+Misevi%C4%8Dius#diff-aW5jbHVkZS91cGEvdXJsX3Jlc3VsdC5o) | `100.00% <100.00%> (ø)` | | | [src/url\_idna.cpp](https://app.codecov.io/gh/rmisev/url_whatwg/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rimas+Misevi%C4%8Dius#diff-c3JjL3VybF9pZG5hLmNwcA==) | `93.33% <66.66%> (+31.11%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.