search

rmisev / url_whatwg

An implementation of the WHATWG URL Standard in C++
https://upa-url.github.io/docs/
Other
9 stars 0 forks source link

Rename all CamelCase functions to snake_case in the url_percent_encode.h #16

Closed rmisev closed 8 months ago

rmisev commented 8 months ago

Rename:

Remove AppendUTF8EscapedValue function and move its content to append_utf8_percent_encoded_char function. Update comments.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0b7d795) 99.72% compared to head (28bc95e) 99.72%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16 +/- ## ========================================== - Coverage 99.72% 99.72% -0.01% ========================================== Files 15 15 Lines 2217 2215 -2 ========================================== - Hits 2211 2209 -2 Misses 6 6 ``` | [Files](https://app.codecov.io/gh/rmisev/url_whatwg/pull/16?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rimas+Misevi%C4%8Dius) | Coverage Δ | | |---|---|---| | [include/upa/url.h](https://app.codecov.io/gh/rmisev/url_whatwg/pull/16?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rimas+Misevi%C4%8Dius#diff-aW5jbHVkZS91cGEvdXJsLmg=) | `99.74% <100.00%> (ø)` | | | [include/upa/url\_host.h](https://app.codecov.io/gh/rmisev/url_whatwg/pull/16?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rimas+Misevi%C4%8Dius#diff-aW5jbHVkZS91cGEvdXJsX2hvc3QuaA==) | `100.00% <100.00%> (ø)` | | | [include/upa/url\_ip.h](https://app.codecov.io/gh/rmisev/url_whatwg/pull/16?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rimas+Misevi%C4%8Dius#diff-aW5jbHVkZS91cGEvdXJsX2lwLmg=) | `100.00% <100.00%> (ø)` | | | [include/upa/url\_percent\_encode.h](https://app.codecov.io/gh/rmisev/url_whatwg/pull/16?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rimas+Misevi%C4%8Dius#diff-aW5jbHVkZS91cGEvdXJsX3BlcmNlbnRfZW5jb2RlLmg=) | `100.00% <100.00%> (ø)` | | | [include/upa/url\_search\_params.h](https://app.codecov.io/gh/rmisev/url_whatwg/pull/16?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rimas+Misevi%C4%8Dius#diff-aW5jbHVkZS91cGEvdXJsX3NlYXJjaF9wYXJhbXMuaA==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.