rmit-programming-club / network-vis

A tool to visualisation coding activity and collaboration within a Github Organisation

GNU General Public License v3.0

9 stars 2 forks source link

Make the website pretty #19

Closed ghost closed 7 years ago

ghost commented 7 years ago

Add Bootstrap v4 and refactor some views

Added gems to support Bootstrap Split our aplication.html.erb into partials, for example we now have a header partial which is rendered on every page

Notes

JONO: the graph css is now located in graph.scss

Issues

I am having some issues with the svg's, I can't get them to center properly....

Old welcome page

old_welcome

New welcome page

new_welcome

ghost commented 7 years ago

@Pancrisp Slight issue, you removed font-awesome from the gemfile, so you should also remove <%= fa_icon 'cog spin' %> from: welcome.html.erb 2 <h1 class="display-3">Work in progress <%= fa_icon 'cog spin' %></h1>

Pancrisp commented 7 years ago

It's still there, I moved them towards the top of the Gemfile.

ghost commented 7 years ago

Oh, yep, didn't see it there -_-

thundergolfer commented 7 years ago

Can you put some screenshots in the PR description? Would be useful to see the improvements, and keep it as a record for tracking project regressions.