rmjarvis / Piff

PSFs In the Full FOV. A software package for modeling the point-spread function (PSF) across the full field of view (FOV). Documentation:
http://rmjarvis.github.io/Piff/
Other
58 stars 13 forks source link

Fix max_snr weight adjustment. #137

Open rmjarvis opened 2 years ago

rmjarvis commented 2 years ago

In the Y6 testing, we discovered (due to a different bug that was fixed in #136) that the weight adjustment we do to bring nominal S/N values down to the requested max_snr value is adding a bit too much noise. If calculateSNR is rerun after this step, the measured SNR is often about 10% lower. Around 90 when the requested max_snr=100. Apparently there is something wrong in the math there, which should be fixed.