search

rmlarose / nisqai-dev

Development repository for NISQAI.
Apache License 2.0
15 stars 4 forks source link

QVM and Quil compiler closing. #12

Open rmlarose opened 5 years ago

rmlarose commented 5 years ago

As of now, if one forgets to catch the output of utils.startQVMandQUILC() and pass this into utils.stopQVMandQUILC(), the processes remain running on their machines. This is undesirable. Ideally, some "safety checks" should be put in place. If not, we must be extremely explicit that this is going to happen, and warn users multiple times.

rmlarose commented 5 years ago

Additionally, it would be great to have checks to see if the processes are running. If they are, utils.startQVMandQUILC should do nothing.

obliviateandsurrender commented 5 years ago

Additionally, it would be great to have checks to see if the processes are running. If they are, utils.startQVMandQUILC should do nothing.

Right now, it kills any previous working processes and restarts the servers. I think I'll add this in stopQVMandQUILC too. Would doing that be okay?

rmlarose commented 5 years ago

Right now, it kills any previous working processes and restarts the servers. I think I'll add this in stopQVMandQUILC too. Would doing that be okay?

Yes, that would be great.

rmlarose commented 5 years ago

Any updates on this @obliviateandsurrender?

obliviateandsurrender commented 5 years ago

Really sorry! Had been busy with some other projects. Will do it latest by tomorrow. Just one quick thing I've wanted to ask is if there's any logger implemented in the system?

rmlarose commented 5 years ago

No worries on the timing! Just checking in on this.

Right now we don't have any logging, no.

obliviateandsurrender commented 5 years ago

Opened a pull request #16. Inform me of any more modifications, if needed.