search

rmlarose / nisqai-dev

Development repository for NISQAI.
Apache License 2.0
15 stars 4 forks source link

QVM and QUILC engine updated #16

Closed obliviateandsurrender closed 5 years ago

obliviateandsurrender commented 5 years ago

As requested in #12 the following has been done:

  1. Implemented an engine class and hence catching the output is no longer necessary.
  2. Implemented separate functions to check the running status of QVM and QUILC servers. checkStatusQVM and checkStatusQUILC.
  3. Separate QVM and QUILC server stop function.
  4. Updated your attempt of testing server START and STOP in cost/_quantum_costs_test.py. I've tested it, and it seems to work fine.
  5. Replaced deprecated HTTPS for RPCQ: [-S -> R], in QUILC server methods.
obliviateandsurrender commented 5 years ago

Fixed Travis and the build is now passing. Also, kindly check your unit test for def test_minimize():. I think it might fail for some random initialized combination of x0.

rmlarose commented 5 years ago

Fantastic! Thanks @obliviateandsurrender!