search

rmmh / skybot

Python IRC bot
https://github.com/rmmh/skybot/wiki
The Unlicense
249 stars 170 forks source link

Consolidate Crypto plugins and Support other Price Basis than USD #186

Closed imnotjames closed 4 years ago

imnotjames commented 6 years ago

This change consolidates all the cryptocurrency plugins (bitcoin & crypto) to make a more uniform experience when retrieving cryptocurrency information.

This also adds the ability to specify an optional price basis for the crypto plugin, so you can compare BTC to ETH, CAD to DOGE, etc.

Old .bitcoin output

USD/BTC: $6,244.57 - High: $6,405.00 - Low: $6,162.06 - Volume: 7,039.66 BTC

New .bitcoin output

BTC/USD: $6261.69 - High: $6409.53 - Low: $6170.47 - Volume: $1377738770.98 - Total Supply: $17262250.00 - Market Cap: $108090858202.50

Comparing ETH to BTC:

ETH/BTC: ₿0.03 - High: ₿0.03 - Low: ₿0.03 - Volume: ₿126163.55 - Total Supply: ₿101897964.97 - Market Cap: ₿2963192.82

Comparing ETH to DOGE:

ETH/DOGE: DOGE 29969.07 - High: DOGE 32391.75 - Low: DOGE 29412.37 - Volume: DOGE 128524844135.04 - Total Supply: DOGE 101897964.97 - Market Cap: DOGE 3053787465581.39
imnotjames commented 5 years ago

Rebased against master. We've been using this one for a while and it's been working pretty well.