rmmh / skybot

Python IRC bot
https://github.com/rmmh/skybot/wiki
The Unlicense
249 stars 170 forks source link

Support both Python3 and Python2 #190

Closed imnotjames closed 5 years ago

imnotjames commented 6 years ago

This uses a bit of the python future tool, along with hand-editing to get skybot to run on both Python2.7 as well as Python3.

Manual Regression Testing

There is no real unit testing in place to ensure things keep working, I'm going to be doing some manual testing.

To Do before Ready

imnotjames commented 6 years ago

If we want to use Travis CI for automated testing, that can be done with tox-travis

rmmh commented 6 years ago

Thanks for all the work! I think #185 is the only item left?

rmmh commented 6 years ago

I'm ok with only supporting Python 3, if it makes this PR simpler.

imnotjames commented 6 years ago

It would not change all that much. Mostly, it'd drop the future dependency and a handful of lines using that. Otherwise, python 2.7/3.0 don't have all that many hard differences.

elitan commented 5 years ago

Nice job. Time to merge!

sklnd commented 5 years ago

LGTM, very exciting

rmmh commented 5 years ago

Thanks for all the work! I just merged this with a minor fix for the cdecl test.