Closed imnotjames closed 5 years ago
If we want to use Travis CI for automated testing, that can be done with tox-travis
Thanks for all the work! I think #185 is the only item left?
I'm ok with only supporting Python 3, if it makes this PR simpler.
It would not change all that much. Mostly, it'd drop the future dependency and a handful of lines using that. Otherwise, python 2.7/3.0 don't have all that many hard differences.
Nice job. Time to merge!
LGTM, very exciting
Thanks for all the work! I just merged this with a minor fix for the cdecl test.
This uses a bit of the python
future
tool, along with hand-editing to get skybot to run on both Python2.7 as well as Python3.print
is now a function rather than a language constructQueue
is now queueU
flag foropen
is deprecated and emits a warning when usedException as e
notation rather thanException, e
.values
rather than.itervalues
.items
rather than.iteritems
thread
is now in the_thread
module.__code__
instead offunc_code
urllib2
modules have been renamed and moved all overManual Regression Testing
There is no real unit testing in place to ensure things keep working, I'm going to be doing some manual testing.
mtg.pyunrelated breakagesnopes.pyunrelated breakagetranslate.pyunrelated breakageTo Do before Ready