search

rmmh / skybot

Python IRC bot
https://github.com/rmmh/skybot/wiki
The Unlicense
247 stars 169 forks source link

don't ignore SSL Cert validity by default #201

Closed imnotjames closed 5 years ago

imnotjames commented 5 years ago

ignoring SSL certificate validity defeats much of the purpose of using SSL certificates in the first place, so the default should be to have that disabled

imnotjames commented 5 years ago

I'd like to point out that this is breaking if people are relying on this... "feature"?

Red-M commented 5 years ago

Not a feature but sometimes IRC nets don't always update their certs, i'd advise a config option to allow for the old "behaviour".

imnotjames commented 5 years ago

Yes, that config option has always been there - this is just changing the default.

The configuration option is ignore_cert. Before this change it was enabled by default which was a bit extreme. Now it's disabled by default, when it's omitted.

imnotjames commented 5 years ago

Oof! looks like this was somehow included by another commit already. I'll fix the docs anyway.