search

rmmh / skybot

Python IRC bot
https://github.com/rmmh/skybot/wiki
The Unlicense
249 stars 170 forks source link

CTCP VERSION throws exception on Windows with GitHub for Windows #58

Closed parkrrr closed 11 years ago

parkrrr commented 12 years ago

I'm using the new GitHub for Windows client and if you run the bot it'll throw exceptions when trying to respond to VERSION requests. The problem is that it can't find Git.

Unhandled exception in thread started by <function run at 0x00000000024ED7B8>
Traceback (most recent call last):
  File "core\main.py", line 66, in run
    out = func(input.inp, **kw)
  File "plugins\misc.py", line 61, in onjoin
    ident, rev = get_version()
  File "plugins\misc.py", line 12, in get_version
    p = subprocess.Popen(['git', 'log', '--oneline'], stdout=subprocess.PIPE)
  File "C:\Python27\lib\subprocess.py", line 679, in __init__
    errread, errwrite)
  File "C:\Python27\lib\subprocess.py", line 893, in _execute_child
    startupinfo)
WindowsError: [Error 2] The system cannot find the file specified
rmmh commented 11 years ago

Does the bot crash?

It should work if you add git to your PATH.