Missing env configuration and setup guidance

rmn316 / NIMBLE

Nimble developer assignment

0 stars 0 forks source link

Missing env configuration and setup guidance #27

Open olivierobert opened 5 years ago

olivierobert commented 5 years ago

robert___Volumes_Workspace__candidates-tests_robert__-_____api-google-scraper_src_index_js__robert_

When running the api-google-scraper, it fails since the port is not defined.

Adding either .env.sample with all required env variables (those with secrets should be left empty) would greatly help in the initial setup. There could even be a setup command to copy the sample env file .env.sample to .env

robert___Volumes_Workspace__candidates-tests_robert__-_____api-google-scraper_src_index_js__robert_

robert___Volumes_Workspace__candidates-tests_robert__-_____api-google-scraper__env__robert_

In addition, documenting the NPM scripts and setup steps would be a big improvement in using the project.

olivierobert commented 5 years ago

I gave up on setting up the app for now until more instructions are provided. Some of the issues I faced:

sequelize-cli fails because babel-register is not defined
The database requires a specific role scraper so I would need to create that
No database seeds are provided and there are no signup forms so I would need to create a user by hand

React_App

rmn316 commented 5 years ago

Pull Request created. https://github.com/rmn316/NIMBLE/pull/28