search

rmnldwg / lymph

Python package for statistical modelling of lymphatic metastatic spread in head & neck cancer.
https://lymph-model.readthedocs.io
MIT License
5 stars 4 forks source link

Bug in comp_diagnose_encoding function of unilateral #56

Closed YoelPH closed 7 months ago

YoelPH commented 7 months ago

There is an issue in the comp_diagnose_encoding function in [unilateral.py](https://github.com/rmnldwg/lymph/blob/main/lymph/models/unilateral.py.

in line 822 we have:

                    lnls=[lnl.name for lnl in self.graph.lnls],

But this does not work as self.graph.lnls is not an object but a dictionary. Hence i propose the following fix:

                    lnls=[lnl for lnl in self.lnls.keys()],
rmnldwg commented 7 months ago

Thanks! This is fixed and tested now in the dev branch and will be merged into main with the next release.