rmohr / qemu-dockerized

test
Apache License 2.0
2 stars 2 forks source link

Enable ValidatingAdmissionWebhook and MutatingAdmissionWebhook apiserver controllers #30

Open davidvossel opened 6 years ago

davidvossel commented 6 years ago

In order for us to test the incoming VirtualMachine webhook functionality, we need both the ValidatingAdmissionWebhook and MutatingAdmissionWebhook controllers enabled on our dockerized environment apiservers.

Example: Our Apiserver should have the following admission controllers enabled.

--admission-control=NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,NodeRestriction,ResourceQuota

https://kubernetes.io/docs/admin/admission-controllers/#is-there-a-recommended-set-of-admission-controllers-to-use

Note that we at one point added Initializers to the list of admission controllers that need to be enabled as a result of our Preset design. Presets ended up not using initializers, and the initializer feature doesn't look like it will be used long term by k8s either, so we can drop that now.