search

rmojgani / RLonKorali

1 stars 3 forks source link

`s["Termination"]`? #10

Closed rmojgani closed 1 year ago

rmojgani commented 1 year ago

@wadaniel Just double checking s["Termination"] with you, If the solution is stable, we set 

 s["Termination"] = "Terminal"

and if unstabnle, going to infinity or blow-up we set

s["Termination"] = "Truncated"

right?

checked in in the ABF3D case

  // Setting finalization status
  if (status == Status::Success)
    s["Termination"] = "Terminal";
  else
    s["Termination"] = "Truncated";

and cartpole case

 # Setting finalization status
 if (cart.isOver()):
  s["Termination"] = "Terminal"
 else:
  s["Termination"] = "Truncated"

If so, is it correct to default into "Truncated" in the flowcontrol

    # TODO?: Termination in case of divergence
    s["Termination"] = "Truncated"
wadaniel commented 1 year ago

correct