search

rmorgan001 / GSServer

ASCOM Synta protocol driver for SkyWatcher and Orion telescope mounts
GNU General Public License v3.0
40 stars 17 forks source link

Added references to GS.Shared resource dictionaries to App.Xaml #3

Closed JPhilC closed 4 years ago

JPhilC commented 4 years ago

Hi Rob,

By way of a small test of how pull requests work I have forked the repository so I have my own copy to work on. I have made a small change adding the language resource dictionaries in GS.Shared as MergedDictionaries in App.xaml. This allows the designer to find the resources at design time.

[Update] Still learning how to use GIT other than as an sole developer! I think I should have created a branch to do the bigger change then I may have been all to create a separate pull request. As it is I have also code to fix the Dec short fall when performing a GoTo.

I have pulled your RA axis precision slew code out into a method of it's own and added a similar method for the Dec axis. Both methods are then called in parallel from SkyGoTo.

If I remember correctly EQASCOM does a final tweak on both axes which is probably why I have never had a problem with that. It may well be that there is a glitch in the AstroEQ firmware which hasn't been picked up over the years because everyone with an AstroEQ will probably be using EQASCOM anyway.

Phil

rmorgan001 commented 4 years ago

references to GS.Shared resource dictionaries and Dec precision goto slews