search

rmorse / search-filter

Search & Filter is a simple search and filtering plugin for WordPress
GNU General Public License v2.0
93 stars 41 forks source link

WP_PLUGIN_URL doesn't take SSL into account #14

Open rcarter opened 9 years ago

rcarter commented 9 years ago

running a site on https gives you a warning of insecure content because it's trying to load the plugin style.css file through http.

see line 31 of search-filter.php

see: https://wordpress.org/ideas/topic/wp_plugin_url-doesnt-take-ssl-into-account

and: http://codex.wordpress.org/Determining_Plugin_and_Content_Directories

I don't have time to put together a pull request for you on this, but it would be a wise change...

rmorse commented 9 years ago

Hey Rob, thanks for the info! I'll get it updated :)

On Thu, Mar 5, 2015 at 5:06 PM, Rob Carter notifications@github.com wrote:

running a site on https gives you a warning of insecure content because it's trying to load the plugin style.css file through http.

see line 31 of search-filter.php

see: https://wordpress.org/ideas/topic/wp_plugin_url-doesnt-take-ssl-into-account

and: http://codex.wordpress.org/Determining_Plugin_and_Content_Directories

I don't have time to put together a pull request for you on this, but it would be a wise change...

— Reply to this email directly or view it on GitHub https://github.com/rmorse/search-filter/issues/14.

Ross Morsali ross@weareelevate.com

We Are Elevate Ltd. 46 Copperfield Street London, SE1 0DY

Mobile: +44 (0) 78 1440 2639 Office: +44 (0) 20 8144 8554

creative development www.weareelevate.com

Intellectual Property Rights & Title of Ownership - All intellectual property rights and title of ownership including, but not limited to; concepts, proposals, layouts, designs, style, typography, colour schemes & flowcharts, websites, online applications, digital media, print materials are reserved and remain the property of or return to We Are Elevate Ltd. while any past, present or future invoices are outstanding and/or until full and final payment has been received. If a project is yet to be commissioned or a purchase order has not been received by We Are Elevate Ltd., all intellectual property rights and title of ownership remain the sole property of We Are Elevate Ltd. Disclaimer, Non-Disclosure & Privacy policy - Any opinions expressed in the email are those of the individual and not necessarily the company. This email and any files transmitted with it are confidential and solely for the use of the intended recipient. If you are not the intended recipient or the person responsible for delivering it to the intended recipient, be advised that you have received this email in error. If you have received this email in error, please accept our apologies for our mistake, and please send it back to info@weareelevate.com to let us know it has gone astray. Any dissemination, distribution, copying or use is strictly prohibited. All information we hold is held in the strictest confidence and will never be intentionally sent to another party. In the event an electronic communication is sent to an incorrect recipient We Are Elevate Ltd. will not accept liability for breach of any non-disclosure agreement unless such agreement specifically prohibits electronic communication of any kind in relation to the subject of the non-disclosure agreement. Should the issuer of any non-disclosure agreement send electronic communication to We Are Elevate Ltd. any previous clause or agreement preventing communication by electronic means will be deemed to be null and void. Liability - We Are Elevate Ltd. accept no liability for any damage or loss of earnings howsoever caused by receiving an electronic communication with or without attachments whether the communication was requested or not. The contents of an attachment to this e-mail may contain software viruses that could damage your own computer system. While the sender has taken every reasonable precaution to minimise this risk, we cannot accept liability for any damage that you sustain as a result of software viruses. You should carry out your own virus checks before opening any attachments to this email. We Are Elevate Ltd. recommend that all recipients have up-to -date anti-virus software installed and correctly configured on their computer. Changes to These Statements - Changes to these statements will occur from time to time. Amendments will be included in relevant sections and dated. Any emails sent on or after the date shown in the amendment are subject to the updates made to any terms and disclaimers.

rcarter commented 9 years ago

awesome... I'm not a wordpress guy, but ran across this on something I was working on for a client, so I figured I'd better mention it...