search

rmosolgo / graphiql-rails

Mount the GraphiQL query editor in a Rails app
MIT License
447 stars 137 forks source link

Rescope rails dependency for flexibility #40

Closed ryanmt closed 6 years ago

ryanmt commented 6 years ago

References #37: Rails association should be more flexible now. The runtime dependency on railties is required for Engine.

References #13: Having a runtime dependency on sprockets-rails explicitly ensures that sprockets will be available for handling application.{css,js} requests.

ryanmt commented 6 years ago

Bah, mistakenly had left the require 'sprockets/railties' in my application.rb, so this doesn't help at all with #13

rmosolgo commented 6 years ago

Sorry for the slow response, but thank you for this refactor! I just shipped 1.4.10 with your improvements 😎