search

rmosolgo / graphiql-rails

Mount the GraphiQL query editor in a Rails app
MIT License
447 stars 137 forks source link

using production react #61

Closed gregology closed 5 years ago

gregology commented 5 years ago

I noticed this gem is using development react which is giving me this error

image

This page is using the development build of React. 🚧

Note that the development build is not suitable for production. 
Make sure to use the production build before deployment.

Open the developer tools, and the React tab will appear to the right.

Is there a reason to use development react instead of production in this instance? If not, here's a quick PR to update it to the production 0.16.0 release. Cheers Team!

gregology commented 5 years ago

Hey @rmosolgo, maybe you have some insight into this? Cheers Mate!

rmosolgo commented 5 years ago

Hey! Sorry about this issue. There's no good reason to use the development version, but I think we need to update the build scripts too:

https://github.com/rmosolgo/graphiql-rails/blob/master/Rakefile#L14

That script bumps the graphiql version and its dependencies automatically. I think we should that too, or else the next update will put the development version in place 😖 . Want to give it a try?

gregology commented 5 years ago

@rmosolgo, neat rake task! Done, do you want me to squash?

rmosolgo commented 5 years ago

Awesome, thanks!

rmosolgo commented 5 years ago

🚢 in 1.7.0!