rmosolgo / graphql-ruby

Ruby implementation of GraphQL
http://graphql-ruby.org
MIT License
5.38k stars 1.39k forks source link

Remove rule that prohibits non-null variables from having default values #5030

Closed rmosolgo closed 4 months ago

rmosolgo commented 4 months ago

This rule isn't actually part of the spec, and GraphQL-JS allows this construction.

From a compatibility standpoint, I don't think this poses any risks: any queries that were previously returned as invalid (wrongly) will now be executed. But I think anyone who encountered this in the past probably removed the !.

Fixes #5029