Use `attr_reader` where applicable

rmosolgo / graphql-ruby

Ruby implementation of GraphQL

http://graphql-ruby.org

MIT License

5.37k stars 1.39k forks source link

Use `attr_reader` where applicable #5080

Closed amomchilov closed 4 weeks ago

amomchilov commented 4 weeks ago

Just a small suggestion Rubocop found a while back.

Methods generated by attr_reader are technically ever-so-slightly faster than regular Ruby methods, though these aren't hot paths, so that doesn't matter much.

rmosolgo commented 4 weeks ago

Thanks for these improvements!