search

rmosolgo / language-graphql

GraphQL support for Atom text editor
MIT License
57 stars 13 forks source link

Update commentStart to use # #5

Closed tonyxiao closed 8 years ago

tonyxiao commented 8 years ago

GraphQL comments start with # not @@

rmosolgo commented 8 years ago

Thanks for this fix! I don't know much about Atom grammars (I really struggled through this one). Can you help me understand what this is for?

I defined comments with # here and that seems to work inside Atom, but what is this other file for? (Somehow, I don't think I even saw it before! 😬 )

tonyxiao commented 8 years ago

I'm not too familiar with atom's grammer either. but this is what happens when you press cmd + / in the editor. Previously it would toggle the line with @@ in front, this commit toggles it with # in front.

rmosolgo commented 8 years ago

Ohhh it's for keyboard shortcuts! Interesting, thanks.

toggle the line with @@ in front

That's terrible, thanks for this fix!

rmosolgo commented 8 years ago

:ship: in 0.4.0!