rmountjoy92 / DashMachine

Another web application bookmark dashboard, with fun features.
GNU General Public License v3.0
1.24k stars 119 forks source link

Added ssl_ignore attribute to http_status platform #111

Closed the4ndy closed 4 years ago

the4ndy commented 4 years ago

Added ssl_ignore attribute to platform to allow users to ignore self-signed or other SSL errors. Defaults to SSL verification ON

[X] I'm submitting editing a platform

Info on changes

I needed to ignore the SSL errors generated when doing an HTTP check on some of my self hosted apps i run locally that have self-signed certs. I did NOT wish to lose the SSL verification check on ALL services I had on my dashboard, so I went ahead and made some changes to the http_status platform.

I did NOT check the example code box, because I could not reliably figure out how / where to edit the "data sources" section text or any other text really for that matter (im bad with templating in pytthon).

I did NOT check the maintenance box because, well, i cant. Trust me, you don't want me messing with the code long term. I am hoping these 4 or 5 lines are helpful, but it took me many hours to get just these few lines working.

the4ndy commented 4 years ago

I just realized, i made this request on the Master branch, idk if you can merge it to the develop or if i need to resubmit, let me know (clearly im bad at this)

marcjmiller commented 4 years ago

I just realized, i made this request on the Master branch, idk if you can merge it to the develop or if i need to resubmit, let me know (clearly im bad at this)

You're not the only one... I only just today realized my previous pull requests included other commits unintentionally... so I asked the same thing.